Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for 0.5 and drop Compat #98

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

iamed2
Copy link
Collaborator

@iamed2 iamed2 commented Jul 9, 2017

Compat wasn't used anymore so I dropped it. If we need it again we can find a new lower version bound.

I also bumped up the IntervalSets dependency.

@iamed2
Copy link
Collaborator Author

iamed2 commented Jul 20, 2017

@mbauman @ajkeller34 thoughts on this?

I also have a branch where I've made some improvements using 0.6-only syntax and would love to push that as well, and get #88 in.

@ajkeller34
Copy link
Collaborator

Looks good to me, though over in #97 @timholy seemed to lean towards finishing and merging #90 before dropping 0.5 support. I'm not sure what the status of that is.

@iamed2
Copy link
Collaborator Author

iamed2 commented Jul 25, 2017

I don't think anyone's around to work on that so I think at this point we could backport it to a 0.5 branch+tag if it gets in to a newer version.

@ajkeller34
Copy link
Collaborator

Ok, I tend to agree. I'll merge this in a few hours if I don't hear from anyone else. I'll close/reopen this PR to trigger CI again in the mean time.

@ajkeller34 ajkeller34 closed this Jul 26, 2017
@ajkeller34 ajkeller34 reopened this Jul 26, 2017
@ajkeller34 ajkeller34 merged commit fe61993 into JuliaArrays:master Jul 26, 2017
@iamed2
Copy link
Collaborator Author

iamed2 commented Jul 26, 2017

Thanks!

@iamed2 iamed2 deleted the pointsix-upgrade branch July 26, 2017 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants