overload permutedims for OneElement matrices

[max-vassili3v]

overload permutedims for OneElementMatrix to return OneElement

[jishnub]

This may be more general, no?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (f659d9f) to head (e84270d).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files           8        8           
  Lines        1106     1110    +4     
=======================================
+ Hits         1105     1109    +4     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dlfivefifty]

@max-vassili3v Can you add this for more general OneElement? At the very least OneElementVector.

[max-vassili3v]

Implemented for more general OneElements, I originally excluded the implementation for OneElementVector since permutedims(::AbstractVector) uses reshape which keeps it as a OneElement

[jishnub]

These tests should check for ===, and not ==.

[jishnub]

Do we need dims to be a Tuple? I think AbstractVectors would also work? Perhaps we may just have permutedims(o::OneElement, dims)?

[dlfivefifty]

Can you add a test for the case where dims is not a Tuple?

[jishnub]

Incidentally, the vector case already works on master, although we perhaps need a specialized method anyway. Perhaps we may define the method in terms of the reshape, as in Base. This way, it'll stay consistent.

julia> o = OneElement(1, 1, 2)
2-element OneElement{Int64, 1, Tuple{Int64}, Tuple{Base.OneTo{Int64}}}:
 1
 ⋅

julia> permutedims(o)
1×2 OneElement{Int64, 2, Tuple{Int64, Int64}, Tuple{Base.OneTo{Int64}, Base.OneTo{Int64}}}:
 1  ⋅