-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overload permutedims for OneElement matrices #368
Merged
jishnub
merged 5 commits into
JuliaArrays:master
from
max-vassili3v:permutedims-oneelement
Aug 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
52314a5
overload for OneElement matrices
max-vassili3v 46dd4fd
add unit test
max-vassili3v b544ecc
more general implementations and unit tests
max-vassili3v 522b0c8
make adjustments
max-vassili3v e84270d
add unit test and style
max-vassili3v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2670,6 +2670,12 @@ end | |
@testset "permutedims" begin | ||
v = OneElement(1, (2,3), (2,5)) | ||
@test permutedims(v) == OneElement(1, (3,2), (5,2)) | ||
w = OneElement(1,3,5) | ||
@test permutedims(w) == OneElement(1, (1,3), (1,5)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These tests should check for |
||
x = OneElement(1, (1,2,3), (4,5,6)) | ||
@test permutedims(x, (1,2,3)) == x | ||
@test permutedims(x, (3,2,1)) == OneElement(1, (3,2,1), (6,5,4)) | ||
@test_throws BoundsError permutedims(x, (2,1)) | ||
end | ||
@testset "show" begin | ||
B = OneElement(2, (1, 2), (3, 4)) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need
dims
to be aTuple
? I thinkAbstractVector
s would also work? Perhaps we may just havepermutedims(o::OneElement, dims)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for the case where
dims
is not aTuple
?