specialize reverse for AbstractFill
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 97.87% 97.89% +0.01%
==========================================
Files 4 4
Lines 660 665 +5
==========================================
+ Hits 646 651 +5
Misses 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dlfivefifty
approved these changes
Dec 7, 2022
src/fillalgebra.jl
Outdated
| @@ -26,6 +26,13 @@ function permutedims(B::AbstractFill, perm) | |||
| fillsimilar(B, dimsP) | |||
| end | |||
|
|
|||
| function reverse(A::AbstractFill, start::Integer=firstindex(A), stop::Integer=lastindex(A)) | |||
| checkbounds(A, start) | |||
There was a problem hiding this comment.
Should we use @propagate_inbounds and @boundscheck ?
|
Tests turn off bounds checking |
|
Should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master
After this PR