Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kron for RectDiagonal fill #272

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 6, 2023

After this,

julia> E = FillArrays.RectDiagonal(Fill(4,300), (300,300));

julia> @btime kron($E, $E);
  1.040 ms (12 allocations: 2.07 MiB)

This runs out of memory on master as it materializes the result.

This PR also optimizes the following:

julia> D = Diagonal(Fill(10, 1000));

julia> @btime sparse($D);
  3.439 μs (3 allocations: 23.88 KiB) # master
  2.250 μs (3 allocations: 23.88 KiB) # PR

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #272 (1491582) into master (e3c8eb9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files           5        5           
  Lines         836      844    +8     
=======================================
+ Hits          834      842    +8     
  Misses          2        2           
Impacted Files Coverage Δ
src/FillArrays.jl 99.45% <100.00%> (+0.01%) ⬆️
src/fillalgebra.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty dlfivefifty merged commit 9be3ba2 into JuliaArrays:master Jul 7, 2023
22 checks passed
@jishnub jishnub deleted the sparserectdiagonal branch July 7, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants