Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import materialize from ArrayLayouts #271

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 26, 2023

Since materialize in ArrayLayouts acts on Mul instances and not Broadcast objects, these need not be the same function. That they are identical currently is an implementation detail, and it's best to not rely on this. This PR imports these from ArrayLayouts instead.

Also, this PR removes certain unused imported macros, and the Base module which doesn't need to be explicitly imported.

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #271 (f4a621d) into master (7009bd1) will increase coverage by 0.19%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   93.55%   93.75%   +0.19%     
==========================================
  Files          14       14              
  Lines        2374     2401      +27     
==========================================
+ Hits         2221     2251      +30     
+ Misses        153      150       -3     
Files Changed Coverage Δ
src/LazyArrays.jl 100.00% <ø> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty dlfivefifty merged commit 57642bf into JuliaArrays:master Dec 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants