Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add == for Zeros-backed CachedArrays #328

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

DanielVandH
Copy link
Contributor

Fixes #327

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (8fc085d) to head (0f02fa3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   94.14%   94.15%   +0.01%     
==========================================
  Files          17       17              
  Lines        3091     3097       +6     
==========================================
+ Hits         2910     2916       +6     
  Misses        181      181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty
Copy link
Member

To fix this properly we want to add an equals_layout to ArrayLayouts.jl a la

https://github.com/JuliaApproximation/QuasiArrays.jl/blob/d9ce29e4cb188ec5b246aaae6242589a11d873c5/src/abstractquasiarray.jl#L506

Then we can compare any AbstractPaddedLayout. But we can merge this as is for now

@dlfivefifty dlfivefifty merged commit a7df659 into JuliaArrays:master Jul 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache(Zeros(n, n)) == cache(Zeros(n, n)) uses matrix ==
2 participants