Fix ambiguity copy(::Mul{<:LazyLayout, <:BandedLayout})
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 94.15% 94.12% -0.04%
==========================================
Files 17 17
Lines 3097 3098 +1
==========================================
Hits 2916 2916
- Misses 181 182 +1 ☔ View full report in Codecov by Sentry. |
|
Can you fix the code cob? |
|
Ah, the BandedMatrices extension wasn't loaded so the ambiguity hadn't been introduced yet. Should be fixed now |
|
Or not. I'll look into the remaining issues soon. |
|
Not sure what the issue is with that line identified by codecov because it should be tested at this point? This should be good to go I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330