Add (col/row)support for Inv(Triangular) #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 94.14% 94.15% +0.01%
==========================================
Files 17 17
Lines 3091 3097 +6
==========================================
+ Hits 2910 2916 +6
Misses 181 181 ☔ View full report in Codecov by Sentry. |
dlfivefifty
added a commit
that referenced
this pull request
Jul 4, 2024
This reverts commit 4fc9005.
dlfivefifty
added a commit
that referenced
this pull request
Jul 4, 2024
|
Oh wait. I accidentally merged this before realising it is in the banded matrix extension. This should not be in an extension |
|
Ah my bad. I thought that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329 (the
(col/row)supportdiscussion anyway)