Avoid depending on LazyArraysBandedMatricesExt from within LazyArraysBlockBandedMatricesExt
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia's loading system ought to allow an extension w/ triggers {B,C}
to depend on an extension w/ triggers {A,C}, under the condition that
B depends on A (i.e. the triggers for the second extension are a strict
subset of the triggers for the first extension)
Unfortunately Julia's purely trigger-based mechanism for extensions does
not actually do that. If `C` is the loaded after `{A,B}` then both of
these extensions will trigger "simultaneously" and they will be loaded
in an indeterminate order.
That problem is the same as the "cycle" in
JuliaLang/julia#55557, so-called because pre-
compilation will try to load each of the simultaneously-triggered
extensions "before" the other repeatedly, leading to an ordering cycle.
This works around the problem by removing the inter-extension dependency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 17 17
Lines 3155 3155
=======================================
Hits 3019 3019
Misses 136 136 ☔ View full report in Codecov by Sentry. |
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LazyArrays reasonably assumes that an extension w/ triggers
{B,C}to can depend on an extension w/ triggers{A,C}- as long as B depends on A.Unfortunately as detailed in JuliaLang/julia#55557, Julia's extension loading does not actually guarantee that. Extension loading is purely trigger-based, so if
Cis the loaded after{A,B}then both of these extensions will trigger "simultaneously" and they will be loaded in an indeterminate order. That can mean that the first extension loads after the second, even though it expected to depend on it.That behavior is arguably a bug and is likely to be improved in a future version of Julia, but for now this works around the problem by removing the inter-extension dependency.