propagate first and last for OffsetRanges #258
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate
first
andlast
to the parent forOffsetArray(::AbstractRange)
. On masterstep
was propagated anyway as this is not defined for abstractarrays in general. The current change is an optimization as it gets around the need to index into the array to find the first element.The
first
andlast
elements for ranges are often obtained by explicitly accessing fields, so I don't think that it's possible to obtain these for wrapper types by using traits.I'm not sure if this provides an immediate real-world performance benefit, so perhaps we may leave this open for now. I had created this keeping something like JuliaLang/julia#41945 in mind. If
iterate
uses traits then we may require a rapid evaluation offirst
andlast
elements forOffsetRange
s to be as performant as ranges.