Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use const for suite #739

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Use const for suite #739

merged 1 commit into from
Feb 19, 2020

Conversation

tkf
Copy link
Member

@tkf tkf commented Feb 19, 2020

ref #736 (comment)

I think it's better to merge this after #737.

@tkf tkf marked this pull request as ready for review February 19, 2020 21:23
@github-actions
Copy link

Benchmark result

Judge result

Benchmark Report for /home/runner/work/StaticArrays.jl/StaticArrays.jl

Job Properties

  • Time of benchmarks:
    • Target: 19 Feb 2020 - 21:30
    • Baseline: 19 Feb 2020 - 21:34
  • Package commits:
    • Target: 6a2c7d
    • Baseline: ff2493
  • Julia commits:
    • Target: 2d5741
    • Baseline: 2d5741
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["qr", "S=1", "SMatrix"] 0.93 (5%) ✅ 1.00 (1%)
["qr", "S=11", "SMatrix"] 0.95 (5%) ✅ 1.00 (1%)
["qr", "S=14", "SMatrix"] 0.91 (5%) ✅ 1.00 (1%)
["qr", "S=15", "SMatrix"] 0.88 (5%) ✅ 1.00 (1%)
["qr", "S=5", "Matrix"] 1.07 (5%) ❌ 1.00 (1%)
["qr", "S=6", "SMatrix"] 0.89 (5%) ✅ 1.00 (1%)
["qr", "S=7", "SMatrix"] 0.90 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["qr", "S=1"]
  • ["qr", "S=10"]
  • ["qr", "S=11"]
  • ["qr", "S=12"]
  • ["qr", "S=13"]
  • ["qr", "S=14"]
  • ["qr", "S=15"]
  • ["qr", "S=16"]
  • ["qr", "S=17"]
  • ["qr", "S=18"]
  • ["qr", "S=19"]
  • ["qr", "S=2"]
  • ["qr", "S=20"]
  • ["qr", "S=21"]
  • ["qr", "S=22"]
  • ["qr", "S=3"]
  • ["qr", "S=4"]
  • ["qr", "S=5"]
  • ["qr", "S=6"]
  • ["qr", "S=7"]
  • ["qr", "S=8"]
  • ["qr", "S=9"]

Julia versioninfo

Target

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.0.0-1031-azure #33-Ubuntu SMP Thu Feb 6 22:26:13 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      28996 s          0 s       2937 s      11289 s          0 s
       #2  2294 MHz      14320 s          0 s       4594 s      23680 s          0 s
       
  Memory: 6.782741546630859 GB (3566.4765625 MB free)
  Uptime: 445.0 sec
  Load Avg:  1.421875  1.08056640625  0.5419921875
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.0.0-1031-azure #33-Ubuntu SMP Thu Feb 6 22:26:13 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      29528 s          0 s       3665 s      29838 s          0 s
       #2  2294 MHz      33830 s          0 s       4851 s      23704 s          0 s
       
  Memory: 6.782741546630859 GB (3437.109375 MB free)
  Uptime: 644.0 sec
  Load Avg:  1.083984375  1.0693359375  0.65380859375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Target result

Benchmark Report for /home/runner/work/StaticArrays.jl/StaticArrays.jl

Job Properties

  • Time of benchmark: 19 Feb 2020 - 21:30
  • Package commit: 6a2c7d
  • Julia commit: 2d5741
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["qr", "S=1", "Matrix"] 106.270 ns (5%) 320 bytes (1%) 4
["qr", "S=1", "SMatrix"] 1.400 ns (5%)
["qr", "S=10", "Matrix"] 12.900 μs (5%) 2.66 KiB (1%) 4
["qr", "S=10", "SMatrix"] 780.000 ns (5%)
["qr", "S=11", "Matrix"] 14.800 μs (5%) 3.22 KiB (1%) 4
["qr", "S=11", "SMatrix"] 1.110 μs (5%)
["qr", "S=12", "Matrix"] 16.401 μs (5%) 3.69 KiB (1%) 4
["qr", "S=12", "SMatrix"] 1.250 μs (5%)
["qr", "S=13", "Matrix"] 18.000 μs (5%) 4.39 KiB (1%) 4
["qr", "S=13", "SMatrix"] 2.067 μs (5%)
["qr", "S=14", "Matrix"] 19.800 μs (5%) 5.33 KiB (1%) 4
["qr", "S=14", "SMatrix"] 2.611 μs (5%)
["qr", "S=15", "Matrix"] 21.300 μs (5%) 5.98 KiB (1%) 4
["qr", "S=15", "SMatrix"] 3.600 μs (5%)
["qr", "S=16", "Matrix"] 31.900 μs (5%) 6.41 KiB (1%) 4
["qr", "S=16", "SMatrix"] 4.586 μs (5%)
["qr", "S=17", "Matrix"] 34.300 μs (5%) 7.34 KiB (1%) 4
["qr", "S=17", "SMatrix"] 47.101 μs (5%) 19.56 KiB (1%) 10
["qr", "S=18", "Matrix"] 35.900 μs (5%) 8.09 KiB (1%) 4
["qr", "S=18", "SMatrix"] 50.000 μs (5%) 21.56 KiB (1%) 10
["qr", "S=19", "Matrix"] 38.601 μs (5%) 9.03 KiB (1%) 4
["qr", "S=19", "SMatrix"] 55.400 μs (5%) 24.06 KiB (1%) 10
["qr", "S=2", "Matrix"] 1.020 μs (5%) 368 bytes (1%) 4
["qr", "S=2", "SMatrix"] 12.513 ns (5%)
["qr", "S=20", "Matrix"] 40.301 μs (5%) 9.78 KiB (1%) 4
["qr", "S=20", "SMatrix"] 56.001 μs (5%) 26.06 KiB (1%) 10
["qr", "S=21", "Matrix"] 43.000 μs (5%) 10.91 KiB (1%) 4
["qr", "S=21", "SMatrix"] 60.400 μs (5%) 29.06 KiB (1%) 10
["qr", "S=22", "Matrix"] 45.300 μs (5%) 11.84 KiB (1%) 4
["qr", "S=22", "SMatrix"] 64.200 μs (5%) 31.56 KiB (1%) 10
["qr", "S=3", "Matrix"] 2.544 μs (5%) 512 bytes (1%) 4
["qr", "S=3", "SMatrix"] 41.271 ns (5%)
["qr", "S=4", "Matrix"] 3.914 μs (5%) 656 bytes (1%) 4
["qr", "S=4", "SMatrix"] 75.826 ns (5%)
["qr", "S=5", "Matrix"] 5.600 μs (5%) 896 bytes (1%) 4
["qr", "S=5", "SMatrix"] 146.126 ns (5%)
["qr", "S=6", "Matrix"] 6.725 μs (5%) 1.11 KiB (1%) 4
["qr", "S=6", "SMatrix"] 192.200 ns (5%)
["qr", "S=7", "Matrix"] 8.100 μs (5%) 1.48 KiB (1%) 4
["qr", "S=7", "SMatrix"] 290.074 ns (5%)
["qr", "S=8", "Matrix"] 9.800 μs (5%) 1.86 KiB (1%) 4
["qr", "S=8", "SMatrix"] 350.952 ns (5%)
["qr", "S=9", "Matrix"] 11.200 μs (5%) 2.19 KiB (1%) 4
["qr", "S=9", "SMatrix"] 606.897 ns (5%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["qr", "S=1"]
  • ["qr", "S=10"]
  • ["qr", "S=11"]
  • ["qr", "S=12"]
  • ["qr", "S=13"]
  • ["qr", "S=14"]
  • ["qr", "S=15"]
  • ["qr", "S=16"]
  • ["qr", "S=17"]
  • ["qr", "S=18"]
  • ["qr", "S=19"]
  • ["qr", "S=2"]
  • ["qr", "S=20"]
  • ["qr", "S=21"]
  • ["qr", "S=22"]
  • ["qr", "S=3"]
  • ["qr", "S=4"]
  • ["qr", "S=5"]
  • ["qr", "S=6"]
  • ["qr", "S=7"]
  • ["qr", "S=8"]
  • ["qr", "S=9"]

Julia versioninfo

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.0.0-1031-azure #33-Ubuntu SMP Thu Feb 6 22:26:13 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      28996 s          0 s       2937 s      11289 s          0 s
       #2  2294 MHz      14320 s          0 s       4594 s      23680 s          0 s
       
  Memory: 6.782741546630859 GB (3566.4765625 MB free)
  Uptime: 445.0 sec
  Load Avg:  1.421875  1.08056640625  0.5419921875
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Baseline result

Benchmark Report for /home/runner/work/StaticArrays.jl/StaticArrays.jl

Job Properties

  • Time of benchmark: 19 Feb 2020 - 21:34
  • Package commit: ff2493
  • Julia commit: 2d5741
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["qr", "S=1", "Matrix"] 111.135 ns (5%) 320 bytes (1%) 4
["qr", "S=1", "SMatrix"] 1.500 ns (5%)
["qr", "S=10", "Matrix"] 13.000 μs (5%) 2.66 KiB (1%) 4
["qr", "S=10", "SMatrix"] 776.842 ns (5%)
["qr", "S=11", "Matrix"] 14.500 μs (5%) 3.22 KiB (1%) 4
["qr", "S=11", "SMatrix"] 1.170 μs (5%)
["qr", "S=12", "Matrix"] 16.400 μs (5%) 3.69 KiB (1%) 4
["qr", "S=12", "SMatrix"] 1.240 μs (5%)
["qr", "S=13", "Matrix"] 18.000 μs (5%) 4.39 KiB (1%) 4
["qr", "S=13", "SMatrix"] 2.022 μs (5%)
["qr", "S=14", "Matrix"] 19.800 μs (5%) 5.33 KiB (1%) 4
["qr", "S=14", "SMatrix"] 2.878 μs (5%)
["qr", "S=15", "Matrix"] 21.600 μs (5%) 5.98 KiB (1%) 4
["qr", "S=15", "SMatrix"] 4.112 μs (5%)
["qr", "S=16", "Matrix"] 33.100 μs (5%) 6.41 KiB (1%) 4
["qr", "S=16", "SMatrix"] 4.557 μs (5%)
["qr", "S=17", "Matrix"] 34.300 μs (5%) 7.34 KiB (1%) 4
["qr", "S=17", "SMatrix"] 47.300 μs (5%) 19.56 KiB (1%) 10
["qr", "S=18", "Matrix"] 36.300 μs (5%) 8.09 KiB (1%) 4
["qr", "S=18", "SMatrix"] 51.200 μs (5%) 21.56 KiB (1%) 10
["qr", "S=19", "Matrix"] 39.600 μs (5%) 9.03 KiB (1%) 4
["qr", "S=19", "SMatrix"] 54.600 μs (5%) 24.06 KiB (1%) 10
["qr", "S=2", "Matrix"] 1.020 μs (5%) 368 bytes (1%) 4
["qr", "S=2", "SMatrix"] 12.613 ns (5%)
["qr", "S=20", "Matrix"] 40.600 μs (5%) 9.78 KiB (1%) 4
["qr", "S=20", "SMatrix"] 56.200 μs (5%) 26.06 KiB (1%) 10
["qr", "S=21", "Matrix"] 43.700 μs (5%) 10.91 KiB (1%) 4
["qr", "S=21", "SMatrix"] 59.800 μs (5%) 29.06 KiB (1%) 10
["qr", "S=22", "Matrix"] 45.200 μs (5%) 11.84 KiB (1%) 4
["qr", "S=22", "SMatrix"] 64.500 μs (5%) 31.56 KiB (1%) 10
["qr", "S=3", "Matrix"] 2.522 μs (5%) 512 bytes (1%) 4
["qr", "S=3", "SMatrix"] 41.271 ns (5%)
["qr", "S=4", "Matrix"] 3.929 μs (5%) 656 bytes (1%) 4
["qr", "S=4", "SMatrix"] 75.826 ns (5%)
["qr", "S=5", "Matrix"] 5.220 μs (5%) 896 bytes (1%) 4
["qr", "S=5", "SMatrix"] 144.577 ns (5%)
["qr", "S=6", "Matrix"] 6.725 μs (5%) 1.11 KiB (1%) 4
["qr", "S=6", "SMatrix"] 216.381 ns (5%)
["qr", "S=7", "Matrix"] 8.100 μs (5%) 1.48 KiB (1%) 4
["qr", "S=7", "SMatrix"] 321.691 ns (5%)
["qr", "S=8", "Matrix"] 9.700 μs (5%) 1.86 KiB (1%) 4
["qr", "S=8", "SMatrix"] 346.190 ns (5%)
["qr", "S=9", "Matrix"] 11.100 μs (5%) 2.19 KiB (1%) 4
["qr", "S=9", "SMatrix"] 630.460 ns (5%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["qr", "S=1"]
  • ["qr", "S=10"]
  • ["qr", "S=11"]
  • ["qr", "S=12"]
  • ["qr", "S=13"]
  • ["qr", "S=14"]
  • ["qr", "S=15"]
  • ["qr", "S=16"]
  • ["qr", "S=17"]
  • ["qr", "S=18"]
  • ["qr", "S=19"]
  • ["qr", "S=2"]
  • ["qr", "S=20"]
  • ["qr", "S=21"]
  • ["qr", "S=22"]
  • ["qr", "S=3"]
  • ["qr", "S=4"]
  • ["qr", "S=5"]
  • ["qr", "S=6"]
  • ["qr", "S=7"]
  • ["qr", "S=8"]
  • ["qr", "S=9"]

Julia versioninfo

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.0.0-1031-azure #33-Ubuntu SMP Thu Feb 6 22:26:13 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      29528 s          0 s       3665 s      29838 s          0 s
       #2  2294 MHz      33830 s          0 s       4851 s      23704 s          0 s
       
  Memory: 6.782741546630859 GB (3437.109375 MB free)
  Uptime: 644.0 sec
  Load Avg:  1.083984375  1.0693359375  0.65380859375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               79
Model name:          Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Stepping:            1
CPU MHz:             2294.684
BogoMIPS:            4589.36
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            51200K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt
Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor :Intel
Architecture :Broadwell
Model Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 51200) kbytes
64 byte cache line size
Address Size 48 bits virtual, 44 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@tkf tkf merged commit c3686c4 into master Feb 19, 2020
@tkf tkf deleted the tkf/const-suite branch February 19, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyferris andyferris andyferris approved these changes

Assignees
No one assigned
Labels
benchmarking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkf @andyferris