implement three-argument similar method (from #94) #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase + cleanup of #94. I've just noticed that before there was a bit of an ambiguity in the interaction with offset arrays.
In the previous version,
whereas with this PR they both give OffsetArrays of StructArrays:
This PR behavior is kind of the only one that is clean to achieve because of the way dispatch is set up (though getting both to return StructArray of OffsetArrays is probably also feasible but a bit more finicky). Is there a principled way to know which format
similar(s::StructArray, rg::UnitRange)
should return?