Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest broadcast implement. #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

N5N3
Copy link
Contributor

@N5N3 N5N3 commented Oct 26, 2023

On master Broadcasted store style by field. Update accordingly.

Test for parent BroadcastStyle with field meta has not been added.
Just run CI to make sure the code works on old julia.

@N5N3 N5N3 force-pushed the newbc branch 2 times, most recently from 503a227 to b8024dd Compare October 26, 2023 15:24
On master `Broadcasted` store style by field. Update accordingly.
@aplavin
Copy link
Member

aplavin commented Mar 8, 2024

I personally don't understand the motivation, what problems exactly does it solve?

@N5N3
Copy link
Contributor Author

N5N3 commented Mar 9, 2024

It should make parent broadcast style with metadata happier.
Though I'm not sure if that kind of usage exists currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants