Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to GPUArraysCore@0.2 #317

Merged
merged 7 commits into from
Nov 16, 2024
Merged

Conversation

pxl-th
Copy link
Contributor

@pxl-th pxl-th commented Nov 12, 2024

  • Use KernelAbstractions.get_backend since GPUArraysCore@0.2 has removed backend function.
  • Fix adapt tests by defining adapt_structure for UnitRange, otherwise it dispatches to the default behavior, which preserves unit range without converting it to array.
  • Bump minimal Julia version to 1.10, since GPUArrays no longer supports lower versions.
  • Set version to 0.7, since bumping Julia version requires minor version bump.

@pxl-th
Copy link
Contributor Author

pxl-th commented Nov 14, 2024

@jishnub @andreasnoack, can you please take a look at this PR?
It is currently blocking several other packages from updating to GPUArraysCore@0.2 (ChainRules.jl, Zygote.jl, NNlib.jl, etc.).

@@ -15,7 +15,6 @@ jobs:
fail-fast: false
matrix:
version:
- '1.6'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make these min, lts, 1, and pre?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@andreasnoack andreasnoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except that it would be good to test on a few more versions.

@andreasnoack andreasnoack merged commit 4400fee into JuliaArrays:master Nov 16, 2024
7 of 8 checks passed
@pxl-th pxl-th deleted the pxl-th/gpuarrays branch November 16, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants