-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to GPUArraysCore@0.2 #317
Conversation
@jishnub @andreasnoack, can you please take a look at this PR? |
@@ -15,7 +15,6 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
version: | |||
- '1.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make these min
, lts
, 1
, and pre
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except that it would be good to test on a few more versions.
KernelAbstractions.get_backend
sinceGPUArraysCore@0.2
has removedbackend
function.adapt_structure
forUnitRange
, otherwise it dispatches to the default behavior, which preserves unit range without converting it to array.0.7
, since bumping Julia version requires minor version bump.