Type Relaxation on sunpos #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aman-Pandey-afk
force-pushed
the
typerelax
branch
2 times, most recently
from
35f32b9
to
93fa229
Compare
Aman-Pandey-afk
force-pushed
the
typerelax
branch
from
a7a4aac
to
71ad81a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #73 .Removed the
_sunposfunction, and used twosunposfunctions with Real andAbstractVector{<:Real}arguments, still casting the output to float to ensure it is type-stable. Works with most of the outputs ofForwardDifffunctions, although can't exactly check the error in the issue as no code is provided to reproduce it.