Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary preserve calls #16

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Remove unnecessary preserve calls #16

merged 2 commits into from
Jul 29, 2021

Conversation

helgee
Copy link
Member

@helgee helgee commented Jul 28, 2021

Fix #15

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #16 (ee92451) into main (c40bc1b) will not change coverage.
The diff coverage is 94.73%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files          27       27           
  Lines        3055     3055           
=======================================
  Hits         3030     3030           
  Misses         25       25           
Impacted Files Coverage Δ
src/g.jl 96.83% <92.30%> (ø)
src/cells.jl 91.93% <100.00%> (ø)
src/t.jl 100.00% <100.00%> (ø)
src/u.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40bc1b...ee92451. Read the comment docs.

@helgee helgee merged commit da08dc1 into main Jul 29, 2021
@helgee helgee deleted the he/unpreserve branch July 29, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all useless calls to GC.@preserve
2 participants