Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project.toml #10

Merged
merged 8 commits into from
Jul 18, 2019
Merged

Project.toml #10

merged 8 commits into from
Jul 18, 2019

Conversation

mileslucas
Copy link
Member

In this pull request I've changed 3(ish) things.

  1. I've added a Project.toml to work with the new Julia standards. I've copied the requirements from REQUIRE and added an appropriate [compat] section.
  2. I've bumped the version to 0.3.0 in the Project.toml
  3. I've switched ° Ra to Ra in the import_from_unitful section since default Unitful has removed the degree symbol

@giordano
Copy link
Member

giordano commented Jul 8, 2019

Thanks!

I've switched ° Ra to Ra in the import_from_unitful section since default Unitful has removed the degree symbol

Do you know in which version of Unitful this change happened? It's important because it'd be probably good to raise the compatible Unitful version.

@mileslucas
Copy link
Member Author

mileslucas commented Jul 8, 2019

It looks like here is where the code was changed, which was release v0.13.0. I've updated the compat to be ≥ 0.13.0.

I've also added julia 1.1 to travis matrix

@mileslucas
Copy link
Member Author

It looks like this causes julia 0.7 to fail at the dependency graph with Unitful and UnitfulAngles

@giordano
Copy link
Member

giordano commented Jul 8, 2019

I'd drop support for Julia 0.7. It has been released almost one year ago, it was meant only for a transition from 0.6 to 1.0, there is no much reason now for people to stay on 0.7

@mileslucas
Copy link
Member Author

I've removed 0.7 from compat, appveyor and the travis matrix, it should pass the CI now.

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to make my final comments the other day! Thanks for the PR, I only have a few minor requests, after that we're good to go!

Project.toml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
appveyor.yml Show resolved Hide resolved
Copy link
Member Author

@mileslucas mileslucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with latest commit!

@giordano giordano merged commit a3a96a3 into JuliaAstro:master Jul 18, 2019
@giordano
Copy link
Member

Thanks!

@@ -0,0 +1,18 @@
name = "UnitfulAstro"
uuid = "f2a1aa4e-5634-4978-a6f6-8c9e368f14ef"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you get this UUID? It's wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I had just randomly generated a UUID, I did not think to check for the UUID from the julia registry

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

julia> using Pkg

julia> Pkg.METADATA_compatible_uuid("UnitfulAstro")
UUID("6112ee07-acf9-5e0f-b108-d242c714bf9f")

😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants