-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project.toml #10
Project.toml #10
Conversation
Thanks!
Do you know in which version of |
It looks like here is where the code was changed, which was release I've also added julia 1.1 to travis matrix |
It looks like this causes julia 0.7 to fail at the dependency graph with Unitful and UnitfulAngles |
I'd drop support for Julia 0.7. It has been released almost one year ago, it was meant only for a transition from 0.6 to 1.0, there is no much reason now for people to stay on 0.7 |
I've removed 0.7 from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot to make my final comments the other day! Thanks for the PR, I only have a few minor requests, after that we're good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with latest commit!
Thanks! |
@@ -0,0 +1,18 @@ | |||
name = "UnitfulAstro" | |||
uuid = "f2a1aa4e-5634-4978-a6f6-8c9e368f14ef" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you get this UUID? It's wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I had just randomly generated a UUID, I did not think to check for the UUID from the julia registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
julia> using Pkg
julia> Pkg.METADATA_compatible_uuid("UnitfulAstro")
UUID("6112ee07-acf9-5e0f-b108-d242c714bf9f")
😉
In this pull request I've changed 3(ish) things.
Project.toml
to work with the new Julia standards. I've copied the requirements fromREQUIRE
and added an appropriate[compat]
section.Project.toml
° Ra
toRa
in the import_from_unitful section since default Unitful has removed the degree symbol