Magnitude Calculations #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realize now there is no way to pin a version to a git branch, so I guess this will have to wait until Unitful updates its version. |
|
in progress: PainterQubits/Unitful.jl@5bdf76e |
|
Thanks @ajkeller34! This should be ready to merge pending any review @giordano |
giordano
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with #12 I went over to Unitful and they resolved the issue (#265 and #267). For now, I've updated
project.tomlto use the master branch of unitful. We should keep an eye on a release and pin that first release here.I've also added some tests to verify the code works as intended (also mirrored in the tests over at Unitful.jl).