Support for astronomical magnitudes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(this is necessary for log units)
Closed
giordano
reviewed
Mar 29, 2019
Unnecessary string I/O removed Co-Authored-By: m-wells <m-wells@users.noreply.github.com>
|
Alright. I think I addressed all the concerns @giordano had. I removed two lines that were no longer needed. Unless there is any other concerns, I think this is ready 😃 |
|
Are we just waiting for @mweastwood to review? |
|
Yep, I'd like him to have a look, since he's the author and maintainer so far of the package. |
mweastwood
approved these changes
Apr 8, 2019
|
Excellent! Can we merge now? 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes issue #8. I've added unit tests, updated the docs to include usage examples, and updated the readme. I even handle color index.