Support for invoking Nanosoldier's runtests from package repositories
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutating it halfway through the process is messy, and was only there because we used to resolve the merge-head very late.
Nanosoldier.jl uses a webhook secret already, which should be sufficient.
maleadt
force-pushed
the
tb/package_mode
branch
from
892a599 to
546d055
Compare
maleadt
force-pushed
the
tb/package_mode
branch
from
93b6103 to
a6d9638
Compare
|
This has been working pretty well, so let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our package ecosystem maturing, there's some core packages that have become difficult to develop because of the amount of dependents. As suggested by @timholy, we should make it possible to invoke Nanosoldier from select package repos in order to determine the inflicted breakage (much the same like how we use Nanosoldier on Base Julia).
I considered having packages invoke PkgEval/Nanosoldier directly, e.g., as part of their CI. However, for the packages that need this (Compat, SnoopPrecompile, Adapt, etc) this quickly becomes problematic, as public CI resources would be insufficient to test all dependents. So instead I'm currently integrating this with the existing infrastructure that runs on MIT hardware. The flip side is that it'll only be available to select repositories.
As part of this PR, I'm also doing a bunch of generic improvements. It would probably be better to separate those out, but that doesn't seem worth it given the specific nature of this package.
Fixes #146