Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests with ASAN #139

Merged
merged 6 commits into from
Jun 14, 2022
Merged

Disable tests with ASAN #139

merged 6 commits into from
Jun 14, 2022

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Jun 13, 2022

Implementing JuliaLang/julia#45195 (comment)

(Note: Redoing #138 on a branch pushed to this repository. I'm wondering if the slug guard is getting in the way. #138 (comment))

@tkf
Copy link
Contributor Author

tkf commented Jun 13, 2022

* Revert "Remove tests with ASAN"
  This reverts commit 32a1d01.
* Revert "WIP: Rollback to `main`"
  This reverts commit e03d47e.
@tkf tkf mentioned this pull request Jun 13, 2022
@tkf
Copy link
Contributor Author

tkf commented Jun 13, 2022

@DilumAluthge @vchuravy Do we want to keep running the tests? Since we know they fail anyway, maybe it's better to just remove it? (i.e., use 32a1d01)

@vchuravy
Copy link
Member

Let's turn of the tests for now

@tkf tkf marked this pull request as ready for review June 14, 2022 02:57
@tkf
Copy link
Contributor Author

tkf commented Jun 14, 2022

OK, I just simply removed the tests

@vchuravy vchuravy merged commit b7a5ac4 into main Jun 14, 2022
@vchuravy vchuravy deleted the tkf/disable-asan-test branch June 14, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants