Don't hard code the analyzegc deps #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
Nov 14, 2022
DilumAluthge
added
the
automerge
vtjnash
reviewed
Nov 16, 2022
|
Can we merge this :)? |
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
DilumAluthge
force-pushed
the
gbaraldi-patch-1
branch
from
891ae05 to
2bc5251
Compare
DilumAluthge
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hard coded makefile call exists so don't hard code it :)
EDIT: The reason for this is so I can pass mimalloc.h to analyzegc. Or any other dep for that matter.