Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote test i686-linux-gnu[net] and gcext to must-pass #344

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Promote test i686-linux-gnu[net] and gcext to must-pass #344

merged 3 commits into from
Jun 24, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Mar 22, 2024 •
edited
Loading

  • Promotes test i686-linux-gnunet and test i686-linux-gnu
  • Promotes gcext

Closes #325

@IanButterworth IanButterworth requested a review from vtjnash March 22, 2024 14:08
@IanButterworth IanButterworth mentioned this pull request Mar 22, 2024
Closed
@vtjnash vtjnash force-pushed the ib/repromote_linux_i686 branch from 279d3bd to b47f240 Compare June 20, 2024 17:58
@IanButterworth IanButterworth added the automerge Kodiak will auto-merge this PR once all CI is green. (This label was previously called "merge me".) label Jun 21, 2024
@IanButterworth

This comment was marked as resolved.

Sign in to view
@IanButterworth

This comment was marked as resolved.

Sign in to view
@IanButterworth
Copy link
Member Author

IanButterworth commented Jun 21, 2024 •
edited
Loading

Same failure 3 times in a row on test i686-linux-gnu

  | 2024-06-21 13:47:24 EDT | misc                                             (10) \|         failed at 2024-06-21T17:47:24.853
  | 2024-06-21 13:47:24 EDT | Test Failed at /cache/build/tester-amdci5-10/julialang/julia-buildkite/julia-01af3e921f/share/julia/test/misc.jl:590
  | 2024-06-21 13:47:25 EDT | Expression: abs(summarysize(z) - 640000) / 640000 <= 0.01
  | 2024-06-21 13:47:25 EDT | Evaluated: 0.18746875 <= 0.01
  | 2024-06-21 13:47:25 EDT

@IanButterworth
Copy link
Member Author

Blocked by JuliaLang/julia#54606 (comment)

@IanButterworth
Copy link
Member Author

Seems like this intermittent issue should also be a blocker JuliaLang/julia#54450

@vtjnash
Copy link
Member

vtjnash commented Jun 23, 2024

We can mark that test_skip or @test skip=true as that test has never worked correctly on i686 (but we missed out on that because it wasn't a must-pass test)

@IanButterworth IanButterworth mentioned this pull request Jun 23, 2024
Merged
@IanButterworth IanButterworth force-pushed the ib/repromote_linux_i686 branch from 9add084 to 97cc19e Compare June 23, 2024 13:20
@IanButterworth
Copy link
Member Author

Hit another failure now


math                                              (7) |         failed at 2024-06-23T13:58:26.792
Test Failed at /cache/build/tester-amdci5-8/julialang/julia-buildkite/julia-2d4ef8a238/share/julia/test/math.jl:1607
  Expression: Core.Compiler.is_foldable(effects)
     Context: effects = (+c,+e,+n,!t,+s,+m,+u,+o)
              T = Float64

@IanButterworth IanButterworth changed the title Promote test i686-linux-gnunet and gcext to must-pass Promote test i686-linux-gnu[net] and gcext to must-pass Jun 23, 2024
@IanButterworth
Copy link
Member Author

JuliaLang/julia#54910

@IanButterworth IanButterworth mentioned this pull request Jun 24, 2024
Merged
@IanButterworth IanButterworth merged commit dea1b33 into JuliaCI:main Jun 24, 2024
5 of 6 checks passed
@DilumAluthge DilumAluthge removed the automerge Kodiak will auto-merge this PR once all CI is green. (This label was previously called "merge me".) label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

promote i686 and gcext to must-pass
3 participants
@IanButterworth @vtjnash @DilumAluthge