In the pre-command, check the General registry tree hash, and only re-download it if there is a hash mismatch
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
changed the title
pre-command, check the General registry tree hash, and only re-download the General registry is there is a tree hash mismatchpre-command, check the General registry tree hash, and only re-download it if there is a hash mismatch
…re-download it if there is a hash mismatch
|
I think the current situation (just don't cache the registries) is working pretty well. This PR adds complexity that we don't necessarily need. |
DilumAluthge
deleted the
dpa/only-download-registry-if-tree-hash-mismatch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged and a new tag is made, we can revert JuliaLang/julia#41934