Add S3Path constructor that takes in S3Path and version #297
Conversation
FWIW this is the behavior I would expect as a user. The same is true of |
Iiiiiiinteresting.
This was actually the path I originally started down, before deciding that failure was the desired end state. Hrm. |
src/s3path.jl
Outdated
| if !isnothing(path.version) | ||
| throw( | ||
| ArgumentError( | ||
| "Can't construct versioned path, input already specifies version: $path" |
There was a problem hiding this comment.
Why not allow the keyword version to overwrite the version of the S3Path silently? Should probably document the rational for this as part of the docstring
|
bors try |
tryBuild failed: |
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
|
Okay, I updated the approach here to be in line with @ararslan's expectations. Rereview required! |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Co-authored-by: Alex Arslan <ararslan@comcast.net>
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Closes #294.
In this PR, fails if input path already has a version; could alternatively implement silently overwriting an existing version.