Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0.6 abstract type declaration depwarn #270

Merged
merged 1 commit into from
Feb 12, 2017

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Feb 11, 2017

DO NOT MERGE NOW!!!!

This requires JuliaLang/Compat.jl#325 and a new tag. I'm using this (and other) PR's to check if the implementation is correct.

Ready now.

@yuyichao
Copy link
Contributor Author

Compat tagged, CI reenabled.

@codecov-io
Copy link

Codecov Report

Merging #270 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files          30       30           
  Lines        2223     2223           
=======================================
  Hits         2131     2131           
  Misses         92       92
Impacted Files Coverage Δ
src/container_loops.jl 98.87% <ø> (ø)
src/heaps.jl 100% <ø> (ø)
src/list.jl 100% <ø> (ø)
src/tokens.jl 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a03f1...5b09322. Read the comment docs.

@yuyichao yuyichao merged commit e9a9cae into JuliaCollections:master Feb 12, 2017
@yuyichao yuyichao deleted the yyc/0.6 branch February 12, 2017 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants