Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Project.toml #424

Merged
merged 2 commits into from
Sep 11, 2018
Merged

add Project.toml #424

merged 2 commits into from
Sep 11, 2018

Conversation

Evizero
Copy link
Contributor

@Evizero Evizero commented Aug 4, 2018

No description provided.

@codecov
Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #424 into master will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   98.72%   98.07%   -0.65%     
==========================================
  Files          30       30              
  Lines        1720     1558     -162     
==========================================
- Hits         1698     1528     -170     
- Misses         22       30       +8
Impacted Files Coverage Δ
src/multi_dict.jl 86.79% <0%> (-13.21%) ⬇️
src/dict_sorting.jl 90% <0%> (-0.91%) ⬇️
src/ordered_dict.jl 91.92% <0%> (-0.81%) ⬇️
src/sorted_dict.jl 97.82% <0%> (-0.33%) ⬇️
src/trie.jl 94.33% <0%> (-0.31%) ⬇️
src/disjoint_set.jl 94.44% <0%> (-0.3%) ⬇️
src/sorted_multi_dict.jl 98.73% <0%> (-0.2%) ⬇️
src/queue.jl 100% <0%> (ø) ⬆️
src/accumulator.jl 100% <0%> (ø) ⬆️
src/ordered_set.jl 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c878918...da4303a. Read the comment docs.

@oxinabox
Copy link
Member

The test time dependency on Primes is real, not a StdLib,
but it doesn't have a Project.toml file.
As such, I believe this is safe
and will not break JuliaCIBot.

Andreas Noack [1 day ago]
Let me clarify. The remaining issue is if a test dependency is a real package and has a project file. Using stdlib during tests should be fine. They don’t have to be declared.

Btw. I think I’m pretty close to a proper fix where CIBot will be using the new package manager but I’ll have to test it a little further.

@oxinabox
Copy link
Member

Ok apparently now everything is fine. because new CIBot was just deployed
So lets do this

@oxinabox oxinabox merged commit bdd7aa0 into JuliaCollections:master Sep 11, 2018
@Evizero Evizero deleted the toml branch September 11, 2018 09:12
@StephenVavasis
Copy link
Contributor

I required Primes in the old version of test_sorted_containers.jl, but this requirement was removed by #426 . I don't know if any other part of DataStructures requires this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants