-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DisjointSets constructor error #568
Fix DisjointSets constructor error #568
Conversation
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=========================================
Coverage ? 87.95%
=========================================
Files ? 32
Lines ? 2109
Branches ? 0
=========================================
Hits ? 1855
Misses ? 254
Partials ? 0
Continue to review full report at Codecov.
|
Just realized this actually still needs work, so don't worry about reviewing or merging it yet. |
Definately add that test case . I should have checked coverage before merging |
Everything seems to be working as expected now, but I'm not entirely confident that this is the best approach to solving the problem. Both this and the Set constructor rely on these lines in arrays.jl which seems a bit counterintuitive. If it doesn't seem like a problem to you though, I'm happy to have this merged and then see about opening a new PR down the road if a more elegant solution becomes apparent. Either way, thanks for taking the time to review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Can you bump the patch version so I can tag a release?
Address error introduced by #567 in situations like the following: