Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use get! instead of haskey/getindex/setindex! #52

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Use get! instead of haskey/getindex/setindex! #52

merged 4 commits into from
Oct 29, 2020

Conversation

kmsquire
Copy link
Member

  • Removes an extra hash lookup

@kmsquire
Use get! instead of haskey/getindex/setindex!
97629e0 
* Removes an extra hash lookup
@kmsquire
Copy link
Member Author

It turns out that this requires Julia 1.1 (and we're currently only testing on Julia 0.7 and 1.0).

I'll leave this open for now.

@kmsquire
Copy link
Member Author

I just discovered https://github.com/marius311/Memoization.jl, which is a nice drop-in replacement for Memoize.jl, and which handles get! nicely.

@marius311, would you be interested in porting your version of memoization here (and become a maintainer)? Memoize.jl has been lacking active maintainership for a while, but it has the benefit of being in the JuliaCollections organization, and your code in Memoization.jl already seems to be a drop-in replacement.

(No worries if you'd rather keep your package separate.)

@kmsquire kmsquire mentioned this pull request Feb 21, 2020
Open
@cstjean cstjean merged commit d6861de into master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmsquire @cstjean