Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doctest to not run twice #559

Closed
wants to merge 1 commit into from
Closed

Conversation

albheim
Copy link
Member

@albheim albheim commented Oct 14, 2021

A recently merged PR in Documenter.jl allows for setting strict checking on certain errors.

We currently ran doctest by itself first before running it when generating documentation, I think this means we would not need to.

Just testing this for now, might need to figure out which errors we should use.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.006 Reference New
❌ 0.048 Reference New
⚠️ 0.016 Reference New
✔️ 0.0 Reference New
✔️ 0.002 Reference New
✔️ 0.002 Reference New
✔️ 0.003 Reference New
✔️ 0.004 Reference New
✔️ 0.012 Reference New
✔️ 0.0 Reference New
✔️ 0.011 Reference New

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (dev@c31d065). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #559   +/-   ##
======================================
  Coverage       ?   85.08%           
======================================
  Files          ?       31           
  Lines          ?     3192           
  Branches       ?        0           
======================================
  Hits           ?     2716           
  Misses         ?      476           
  Partials       ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31d065...fea7420. Read the comment docs.

@albheim albheim closed this Oct 14, 2021
@albheim albheim deleted the albheim/update_doctest branch October 15, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants