Don't treat Q's like easily readable arrays #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
commented
Jul 30, 2022
dkarrasch
commented
Jul 30, 2022
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Codecov Report
@@ Coverage Diff @@
## master #725 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 37 37
Lines 3877 3877
=======================================
Hits 3546 3546
Misses 331 331
Continue to review full report at Codecov.
|
|
Thank you for the fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in a nanosoldier run in JuliaLang/julia#46196. Independently from that PR, this usage of
reverthere is supposedly really slow, because there's no quickgetindexforqr(A).Qs. I added calls toMatrix, which may yield rectangular matrices in the tall case. I'll propose another solution below if you insist on the square representation.