Fix 0.6 abstract type declaration depwarn #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compat tagged, CI reenabled. |
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 7 7
Lines 294 294
=======================================
Hits 290 290
Misses 4 4
Continue to review full report at Codecov.
|
|
I'm amazed that Compat |
|
I don't think it'll be that hard to keep it working on 0.3 either (I still haven't delete my 0.3 tree yet....). |
|
Tim's about to delete a bunch of that code from Compat unless somebody tells him not to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE NOW!!!!This requires JuliaLang/Compat.jl#325 and a new tag. I'm using this (and other) PR's to check if the implementation is correct.Ready now.