Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few deprecations on Julia 0.7 #207

Merged
merged 3 commits into from
Jul 6, 2018
Merged

Fix a few deprecations on Julia 0.7 #207

merged 3 commits into from
Jul 6, 2018

Conversation

martinholters
Copy link
Member

Remaining deprecation warnings at the moment are all due to the moval of mean and middle to Statistics. I'll fix those once JuliaLang/Compat.jl#583 has landed. Whether as part of this PR or in another one is a matter of how fast we get the Compat. I'd like to tag a version with the new unwrap soon, but wanted to fix those deprecations where it was easy. So if the Statistics thing takes its time, I'll tag before, despite the remaining deprecations.

@martinholters
Copy link
Member Author

martinholters commented Jul 5, 2018

esprit: Test Failed at /home/travis/build/JuliaDSP/DSP.jl/test/estimation.jl:20
  Expression: isapprox(frequencies', frequencies_estimated; atol=0.01)
   Evaluated: isapprox([1000.0; 1250.0], [999.958, 1249.95]; atol=0.01)

in one of the CI runs. We should probably loosen the bound here. EDIT: Restarted that job.

@martinholters martinholters merged commit d5bd196 into master Jul 6, 2018
@martinholters martinholters deleted the mh/fixdeps_0.7 branch July 6, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant