-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for IOBuffer containing Memory
#1125
Conversation
Memory
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
==========================================
- Coverage 90.41% 90.25% -0.17%
==========================================
Files 9 9
Lines 2305 2308 +3
==========================================
- Hits 2084 2083 -1
- Misses 221 225 +4 ☔ View full report in Codecov by Sentry. |
The good news is that the library prrcompiles on nightly, the bad news is that it fails 😅. I'm gonna check what is wrong |
@ViralBShah the tests now pass on nightly. the doc errors are due to Documenter 1.0 strict setting. another PR for that is coming. |
@oscardssmith Is this good to merge (since you brought this to my attention)? |
It looks reasonable to me. The entire |
I'll merge for now to fix the breakage elsewhere. |
Needs a new version for breakage to be fixed. |
I've kicked off a new release |
tries to fix #1124