Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for IOBuffer containing Memory #1125

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

longemen3000
Copy link
Contributor

tries to fix #1124

@longemen3000 longemen3000 changed the title support for IOBuffer containing memory support for IOBuffer containing Memory Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.25%. Comparing base (66a3a65) to head (ea8796f).

Files Patch % Lines
src/utils.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   90.41%   90.25%   -0.17%     
==========================================
  Files           9        9              
  Lines        2305     2308       +3     
==========================================
- Hits         2084     2083       -1     
- Misses        221      225       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@longemen3000
Copy link
Contributor Author

The good news is that the library prrcompiles on nightly, the bad news is that it fails 😅. I'm gonna check what is wrong

@longemen3000
Copy link
Contributor Author

@ViralBShah the tests now pass on nightly. the doc errors are due to Documenter 1.0 strict setting. another PR for that is coming.

@ViralBShah
Copy link
Contributor

@oscardssmith Is this good to merge (since you brought this to my attention)?

@oscardssmith
Copy link
Contributor

It looks reasonable to me. The entire getbytebuffer should probably be removed entirely since it's a function who's whole purpose is to violate the IOBuffer abstraction, but within the current framework, this seems like a good fix.

@ViralBShah
Copy link
Contributor

I'll merge for now to fix the breakage elsewhere.

@ViralBShah ViralBShah enabled auto-merge (squash) February 28, 2024 04:21
@ViralBShah ViralBShah merged commit 141e2e4 into JuliaData:main Feb 28, 2024
8 of 10 checks passed
@KristofferC
Copy link
Contributor

Needs a new version for breakage to be fixed.

@quinnj
Copy link
Member

quinnj commented Mar 2, 2024

I've kicked off a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV.jl errors on nightly
5 participants