Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
  • Loading branch information
greimel and nalimilan authored Sep 20, 2019
1 parent 624b724 commit 10e044a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion src/extras.jl
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ function cut(x::AbstractArray{T, N}, breaks::AbstractVector;
extend::Bool=false,
labels::Union{AbstractVector{<:AbstractString},Function}=default_formatter,
allow_missing::Bool=false) where {T, N}

if !issorted(breaks)
breaks = sort(breaks)
end
Expand Down
2 changes: 1 addition & 1 deletion test/15_extras.jl
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ end
@test levels(x) == ["[2.0, 3.5)", "[3.5, 5.0]"]
end

@testset "formatter function" begin
@testset "cut with formatter function" begin
my_formatter(from, to, i; closed) = "$i: $from -- $to"

x = 0.15:0.20:0.95
Expand Down

0 comments on commit 10e044a

Please sign in to comment.