Remove useless in() methods #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not actually needed for standard collections, which rely on isequal() or == and hash(). They create ambiguities and can even be incorrect, e.g. for ObjectIdDict. They could even be less efficient than the default if we stored hashes and implemented optimized hash(::CatValue, ::UInt) methods. For reference, they have been introduced in 9638d31.
|
Merged as 412eb3b, but for some reason GitHub hasn't realized it. |
ExpandingMan
pushed a commit
to ExpandingMan/CategoricalArrays.jl
that referenced
this pull request
Mar 1, 2018
These are not actually needed for standard collections, which rely on isequal() or == and hash(). They create ambiguities and can even be incorrect, e.g. for ObjectIdDict. They could even be less efficient than the default if we stored hashes and implemented optimized hash(::CatValue, ::UInt) methods. For reference, they have been introduced in 9638d31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not actually needed for standard collections, which rely on
isequalor==andhash. They create ambiguities and can even be incorrect, e.g. forObjectIdDict. They could even be less efficient than the default if we stored hashes and implemented optimizedhash(::CatValue, ::UInt)methods (#61). For reference, they have been introduced in 9638d31 (#66).Fixes #127.