fix unique() behaviour, add unique!() #358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Jul 9, 2021
|
This does sound like a good solution. |
alyst
changed the title
|
gentle bump |
nalimilan
reviewed
Aug 17, 2021
src/array.jl
Outdated
| @@ -854,7 +841,15 @@ end | |||
| Drop levels which do not appear in categorical array `A` (so that they will no longer be | |||
| returned by [`levels`](@ref DataAPI.levels)). | |||
| """ | |||
| droplevels!(A::CategoricalArray) = levels!(A, intersect(levels(A), uniquelevels(A))) | |||
| function droplevels!(A::CategoricalArray) | |||
| # FIXME temporary code until PR#359 is merged | |||
There was a problem hiding this comment.
Just a note so that we don't forget this before merging (x-ref #359).
There was a problem hiding this comment.
I've just rebased the PR against the updated droplevels!() and squashed the commits, so it should be ready for merging (when it's time for a new minor release).
so it conforms to the semantics of the Base.unique() This is a breaking change that requires a new minor release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft of a solution for #357, this PR renamesunique(::CategoricalArray)touniquelevels(::CategoricalArray)as it better reflects what this method doesThis PR restores the
Base.unique()behavior -- makesunique(x::CategoricalArray)return the categorical array of the same type asxand containing the unique values ofxin the order of their first appearance.The internal implementation of
unique()is cleaned up and optimized a bit (avoid intermediate array sorting, generalize toAbstractCategoricalArray).The PR also adds
Base.unique!(x::CategoricalArray).The newunique()is not yet covered by unit tests. I'll do that if the overall approach would be considered ok.If you need the old
unique(x::CategoricalArray)behavior, useunwrap.(unique(x)).As this is backward-incompatible change, the new minor version would be required.
Needs to be rebased once #359 lands.Fixes #357, #129.