Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add droplevels! function for removing unused pool values #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Nov 22, 2020

No description provided.


For an array `A` that implements [`levels`](@ref DataAPI.levels)), certain levels may
become "unused" via array modification, meaning the values still exist in the array
"pool", but are no longer present in the actual array values. `droplevels!` remove
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a reference to refpool explicitly rather than "pool"?

"pool", but are no longer present in the actual array values. `droplevels!` remove
such values to ensure `levels` only returns values that currently exist in the array.

This generic function is owned by DataAPI.jl itself, which is the sole provider of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in CategoricalArrays.jl droplevels! returns A. @nalimilan probably can comment better here about the design assumptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants