Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of eltypes #1596

Closed
bkamins opened this issue Nov 13, 2018 · 8 comments · Fixed by #1940
Closed

Future of eltypes #1596

bkamins opened this issue Nov 13, 2018 · 8 comments · Fixed by #1940
Milestone

Comments

@bkamins
Copy link
Member

bkamins commented Nov 13, 2018

Since now we can write eltypes(df) as eltype.(columns(df)) there is a question do we want to keep eltypes function?

@pdeffebach
Copy link
Contributor

We also have a more readable describe for getting a quick picture of a DataFrame, including its eltypes, which is what I imagine this is mostly being used for. So I vote to drop it.

@bkamins bkamins mentioned this issue Jan 15, 2019
31 tasks
@bkamins
Copy link
Member Author

bkamins commented Feb 6, 2019

OK - so the decision is to deprecate eltypes?

@nalimilan
Copy link
Member

Not sure. I know I was the one who wanted to kill it, but maybe it's fine to keep it. The main gripe with eltypes is that it's column-oriented while we've decided functions should operate on rows by default (#1514), but there are other functions like this that we won't deprecate (names, describe, allowmissing!, categorical!...).

@nalimilan nalimilan added this to the 1.0 milestone Feb 6, 2019
@bkamins
Copy link
Member Author

bkamins commented Feb 6, 2019

We can leave it as is for me, so I am OK, if you close this.

Alternatively we could deprecate these names and add a preffix, e.g. col, to all of them. But I am not sure if it is worth it, so I did not even propose it later.

Alternatively we could clearly document which functions work by columns and which by rows (most of the time this is pretty natural).

@bkamins
Copy link
Member Author

bkamins commented Sep 2, 2019

I think eltypes is hardly used nowdays, but it does not hurt so maybe let us keep it.

In summary - I am closing this, but please reopen if you feel it needs more debate.

@bkamins bkamins closed this as completed Sep 2, 2019
@nalimilan
Copy link
Member

I think eltypes is hardly used nowdays, but it does not hurt so maybe let us keep it.

That sentence isn't the most convincing argument. ;-)

I've opened #1940 to see what changes the deprecation would imply. It's not too bad, so maybe we should merge it. As always, it's easier to reintroduce convenience functions if needed than the reverse.

@bkamins
Copy link
Member Author

bkamins commented Sep 3, 2019

Well - it was a stream of thoughts :) rather than an argument

@kescobo
Copy link
Contributor

kescobo commented Sep 3, 2019

More functions that do similar things = less readability, more confusion, and more to maintain. Esp. given describe(), and the ability to broadcast eltype() on columns, I think removing it makes a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants