Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate eltypes #1940

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Deprecate eltypes #1940

merged 2 commits into from
Sep 6, 2019

Conversation

nalimilan
Copy link
Member

@nalimilan nalimilan commented Sep 3, 2019 •
edited
Loading

Here's how it looks.

Fixes #1596.

@nalimilan nalimilan mentioned this pull request Sep 3, 2019
Closed
bkamins
bkamins approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - it is easy enough to live without it :)

@bkamins bkamins added this to the 1.0 milestone Sep 3, 2019
@nalimilan nalimilan changed the title RFC: Deprecate eltypes Deprecate eltypes Sep 6, 2019
@nalimilan
Copy link
Member Author

Merging since we only got positive replies.

@nalimilan nalimilan merged commit 0161c0d into master Sep 6, 2019
@nalimilan nalimilan deleted the nl/eltypes branch September 6, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Future of eltypes
2 participants
@nalimilan @bkamins