Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete! in DataFrames.jl #2853

Closed
bkamins opened this issue Sep 2, 2021 · 1 comment · Fixed by #2854
Closed

delete! in DataFrames.jl #2853

bkamins opened this issue Sep 2, 2021 · 1 comment · Fixed by #2854
Labels
breaking The proposed change is breaking. decision feature
Milestone

Comments

@bkamins
Copy link
Member

bkamins commented Sep 2, 2021

We currently have delete! to remove rows from a DataFrame. However, delete! is defined for collections in Julia Base REMOVING A MAPPING for a passed key. Clearly this is not what delete! in DataFrames.jl does.

I propose to:

  • deprecate delete! (it is a long term deprecation - it does not hurt to keep it)
  • what delete! does should be deleteat!
  • additionally implement keepat! to match Julia 1.7 behavior

(the issue is prompted by the fact that when we add keepat! it is strange to have delete! as its counterpart)

CC @nalimilan and @oxinabox (for end-user opinion as usual 😄)

@bkamins bkamins added breaking The proposed change is breaking. decision feature labels Sep 2, 2021
@bkamins bkamins added this to the 1.3 milestone Sep 2, 2021
@nalimilan
Copy link
Member

For reference, I introduced delete! at #2189 but it should clearly have been called deleteat!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking The proposed change is breaking. decision feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants