[BREAKING] Rename deleterows! to delete! #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`delete!` was renamed to `deletecols!` a few releases ago, now it's time to finish the plan and rename `deleterows!` to `delete!` for consistency with the rest of the API that treats data frames as collections of rows.
bkamins
changed the title
bkamins
approved these changes
Apr 15, 2020
|
I'd rather leave that for later. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete!was renamed todeletecols!a few releases ago, now it's time to finish the plan (#1514) and renamedeleterows!todelete!for consistency with the rest of the API that treats data frames as collections of rows.