-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pivot() funtion (for updated pull request #1175) #1181
Conversation
While the original pull request JuliaData#1175 was done directly online on github, this is done in the more classic clone, commit & pull way. This commit implements the original pivot() function and the comments by @ararslan: - added test - used lowercase - 4 spaces idents - removed parenthesis around if statements - reformatted docstring (following those of unstack())
See Panda's |
Hi.. thank you for your comment.. actually the proposed
I don't think two separate |
Sorry for the delay. I'm fine with adding
Regarding the implementation:
EDIT: |
@nalimilan - I think I would prefer to have |
Well FreqTables is for frequency tables, but no frequencies are involved here. |
I know, but "frequency" is just It all depends how much you want to invest into FreqTables.jl. |
Yeah I guess we could have a function which makes sense for frequencies, but also happens to be more generally useful. Though it could also make sense to have it in DataFrames. It's hard to write it using the Tables.jl API anyway since it relies on many DataFrames-specific functions (AFAICT). |
We could add Alternatively I can implement a limited functionality similar to proposed here in DataFrames.jl (i.e. producing a |
Also the question is if we need it as it is essentially an |
I don't have a strong opinion. I guess we can wait until somebody cares enough to make a PR. |
I will add a description of |
Closed in favor of #2998. |
While the implementation of pull request #1175 was done directly online on github.com, this is done in the more classic clone, commit & pull way (as I wasn't able to add files to the pull request online).
This commit implements the original pivot() function that was the subject of pull request #1175 and the subsequent comments by @ararslan: