Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak deprecated readtable(GZip) #1341

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Unbreak deprecated readtable(GZip) #1341

merged 1 commit into from
Jan 8, 2018

Conversation

andreasnoack
Copy link
Member

I.e. use the CodecZLib API since we don't load GZip anymore. This broke the RDatasets tests.

nalimilan
nalimilan reviewed Jan 8, 2018
View reviewed changes
src/deprecated.jl Outdated
end

return readtable(io,
_r(io) = readtable(io,
nbytes,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change indentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@andreasnoack andreasnoack mentioned this pull request Jan 8, 2018
Merged
nalimilan
nalimilan approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge and tag a release to fix RDatasets.

@andreasnoack andreasnoack merged commit 9c0b802 into master Jan 8, 2018
@andreasnoack andreasnoack deleted the anj/gzip branch January 8, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreasnoack @nalimilan