Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix push!(df, a, b, ...) #1398

Merged
merged 4 commits into from
Apr 19, 2018
Merged

Fix push!(df, a, b, ...) #1398

merged 4 commits into from
Apr 19, 2018

Conversation

cstjean
Copy link
Contributor

@cstjean cstjean commented Apr 18, 2018

This method assumes that push!(df, x) returns df.

@nalimilan
Copy link
Member

Thanks. Test failures are unrelated and will be fixed by JuliaLang/METADATA.jl#14324.

Does the new test you added cover both changes?

@nalimilan nalimilan closed this Apr 19, 2018
@nalimilan nalimilan reopened this Apr 19, 2018
@cstjean
Copy link
Contributor Author

cstjean commented Apr 19, 2018

Thank you for the cleanup.

@ararslan ararslan merged commit 3b762a2 into JuliaData:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstjean @nalimilan @ararslan