Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Between and All #1914

Merged
merged 8 commits into from
Aug 12, 2019
Merged

Add Between and All #1914

merged 8 commits into from
Aug 12, 2019

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Aug 7, 2019

Adds Between and All column indexing

src/abstractdataframe/abstractdataframe.jl Outdated Show resolved Hide resolved
src/abstractdataframe/abstractdataframe.jl Outdated Show resolved Hide resolved
src/other/index.jl Outdated Show resolved Hide resolved
src/other/index.jl Outdated Show resolved Hide resolved
@nalimilan
Copy link
Member

Cool. Don't forget to bump the required DataAPI version. X-ref JuliaData/DataAPI.jl#7

@bkamins
Copy link
Member Author

bkamins commented Aug 11, 2019

@nalimilan OK to merge this?

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion about version requirements. Since DataAPI has reached 1.0, probably better require 1.x.

Project.toml Outdated Show resolved Hide resolved
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins
Copy link
Member Author

bkamins commented Aug 11, 2019

@nalimilan - I understand that what you proposed now (a strict reference to DataAPI.jl version) is what we should use - right? If you confirm I will merge this. Thank you.

@bkamins bkamins merged commit 445ecd9 into JuliaData:master Aug 12, 2019
@bkamins bkamins deleted the add_between_and_all branch August 12, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants