-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Between and All #1914
Add Between and All #1914
Conversation
Cool. Don't forget to bump the required DataAPI version. X-ref JuliaData/DataAPI.jl#7 |
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
@nalimilan OK to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion about version requirements. Since DataAPI has reached 1.0, probably better require 1.x.
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
@nalimilan - I understand that what you proposed now (a strict reference to DataAPI.jl version) is what we should use - right? If you confirm I will merge this. Thank you. |
Adds
Between
andAll
column indexing