fix deprecation for setindex! using 1-row DataFrame #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
approved these changes
Aug 25, 2019
|
What was mildly non-breaking, but on the border is:
And what is breaking is #1899 (as I disallow some old functionality). So if it is OK with you I would:
and leave #1899 for later (this is a complex PR so it is better to sleep over it). Please confirm if we can go this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://discourse.julialang.org/t/overwrite-partial-dataframe-row-with-new-array/27953.
@nalimilan After this is merged we should tag a release. Ideally I would also merge #1925 and #1899 if they could be ready relatively soon (I have time to work on it) and then tag 0.20.0 release (this is my preferred option if you have time to have a look, especially at #1899 which is large). Otherwise we should just pick this PR over 0.19.3 and tag 0.19.4 with only this fix.