Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using makeunique=true for grouping keys in combine #1938

Merged
merged 3 commits into from
Sep 3, 2019
Merged

Stop using makeunique=true for grouping keys in combine #1938

merged 3 commits into from
Sep 3, 2019

Commits on Sep 3, 2019

  1. Stop using makeunique=true for grouping keys in combine 

    Instead, check whether columns with the same names as grouping keys
have been returned, and throw an error if they are not equal.
This is breaking since columns named key_1, etc. won't be created,
but in practice it should not be frequently used. Introducing a deprecation
would be more annoying than helpful since it would require adding a keyword
argument to disable adding grouping keys and force users to set it to silence
the warning, which happens in most common cases.
    @nalimilan
    nalimilan committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    0bbd96f View commit details
    Browse the repository at this point in the history

  2. Add more stringent test 

    To check that names are used, and not only column indices.
    @nalimilan
    nalimilan committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    6ebf3d2 View commit details
    Browse the repository at this point in the history

  3. Also fix map, add mention in docstring

    @nalimilan
    nalimilan committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    9248c88 View commit details
    Browse the repository at this point in the history