-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correctly use dotview instead of maybeview in broadcasting contexts #1960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea whether that's appropriate, I let you judge.
(Apparently one can't remove empty lines at end of files using GitHub...)
I judge it is appropriate, as it works and I understand why 😄 (so this is not a hacky patch). However, I will wait a few days as maybe @mbauman might have some comments here. |
Having slept over this PR: What is going on:
This change fixes #1959 in broadcasting contexts but also fixes usage of views in non-broadcasting contexts, like |
Improve warning message for
df[col]
in broadcasted assignment.